AO3-5860 Update tests for error message when commenting as admin

[ceithir]

Do the admin check first

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-5860

Purpose

Follow-up of #4378
Fix conflict with #4556

I'm actually not sure this is the best solution. Moving first the admin restriction is far more consistent as admins can never comment whatever the circumstances. But I suspect some admins might have a workflow where they check for messages like "you can't add or edit comments on a hidden work". -> Yeah, too many side effects.

For now, I've just updated the tests to match the current behavior. If that behavior is not the intended one, I'm not against a ticket detailing what is expected especially as it has been a long time since my last foray into this.

[Bilka2]

Instead of moving this above the other checks, do you think it would make sense to adjust the anon commenting checks to check for admin login instead? Specifically I am thinking that the two !logged_in? in this elsif chain could be guest? instead, because that also checks the admin login.

The reasoning for my idea is that I imagine that admins would like to be able to see the effect of the comment setting on the work without always getting the "please log out" message. But this is just an idea, I am not sure what the best solution is.

[ceithir]

After sleeping on it, I would be in favor of a quick Scope: Tests Only PR right now to fix the build, and then an addendum to AO3-5860 or a new ticket altogether to rework the behavior (if need be).