AO3-5763 AO3-5348 Add more info to gift notification email and internationalize it #4137
Conversation
We don't want empty lines if some tag type is missing.
…n the right language
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -60,4 +60,11 @@ def time_ago_in_words(from_time, include_seconds = false) | |||
|
|
|||
| alias distance_of_time_in_words_to_now time_ago_in_words | |||
|
|
|||
| # Take some text and add whatever punctuation, symbols, and/or spacing | |||
| # we use to separate a metadata property from its value, e.g., "Property: ", | |||
| # "Propriété : ". | |||
There was a problem hiding this comment.
Style/AsciiComments: Use only ascii symbols in comments.
There was a problem hiding this comment.
Va te faire enculer, Hound. It's French.
There was a problem hiding this comment.
Duo serait très fier de toi :P
There was a problem hiding this comment.
Yeah we don't have to do anything here. This check will eventually be phased out (rubocop/rubocop#9674).
| <%= work_metadata_label(Work.human_attribute_name("chapter_total_display"))%><%= work.chapter_total_display %> | ||
| <%= work_tag_metadata(work.fandoms) %> | ||
| <%= work_tag_metadata(work.ratings) %> | ||
| <%= work_tag_metadata(work.archive_warnings) %><% unless work.relationship_string.blank? %> |
There was a problem hiding this comment.
(It's like this so we don't end up with extra blank lines in the email when a tag type is not present.)
There was a problem hiding this comment.
Counterintuitively enough, I think you can actually prevent extra blank lines in the output by adding newlines. A template like this produces three blank lines:
<% if false %><%= "Text." %><% end %>
<% if false %><%= "Text." %><% end %>
<% if false %><%= "Text." %><% end %>
Whereas a template like this produces no blank lines:
<% if false %>
<%= "Text." %>
<% end %>
<% if false %>
<%= "Text." %>
<% end %>
<% if false %>
<%= "Text." %>
<% end %>
(This is because a <% %> tag that's alone on the line doesn't affect the output. But multiple tags in one line are trickier.)
There was a problem hiding this comment.
Oh, that would be much better -- thanks!
| <% else %> | ||
| <%= style_creation_link(@work.title, collection_work_url(@collection, @work)) %> <%= "(#{@work.word_count} words)" %> | ||
| <% end %> | ||
| <% url = @collection ? collection_work_url(@collection, @work) : work_url(@work) %> |
There was a problem hiding this comment.
(The work title/byline is separate from the other metadata because subscription emails display this info differently.)
| <% unless work.summary.blank? %> | ||
|
|
||
| <%= work_metadata_label(Work.human_attribute_name("summary")) %> | ||
| <%= raw to_plain_text(sanitize_field(work, :summary)) %> |
There was a problem hiding this comment.
Should this be indented 2 spaces?
There was a problem hiding this comment.
Nope, I wanted to match the indenting from the subscription emails (I assume we went with four spaces because it's more obviously done for a pretty formatting effect than two -- two just looks kinda like we misaligned the text):
|
|
||
| # We don't use .to_sentence because these aren't links and we risk making any | ||
| # connector word (e.g., "and") look like part of the final tag. | ||
| def work_tag_metadata_list(tags) |
There was a problem hiding this comment.
Is this used directly in a view? If so, we should make it private and keep the list of available helpers shorter.
Then we can have specs just for the public ones as well.
…ags), and style_work_tag_metadata_list(tags) private and do not test individually
redsummernight
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
Issue
https://otwarchive.atlassian.net/browse/AO3-5348
https://otwarchive.atlassian.net/browse/AO3-5763
Purpose
Make sure the gift notification email includes the same info we'd send for a subscription notification. Accomplishes this using a partial we can reuse across many emails. I did not update the subscription emails to use the partial, even though it's the same info and formatting -- I can add that change if we'd like.
Also makes the email translatable and fixes an issue where the subject was always in English.
Testing Instructions
Give people gifts! Check how the emails look in various languages, HTML and plain text!
Credit
Sarken, she/her