container: Drop async_compression + support zstd:chunked #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically just a workaround for Nullus157/async-compression#271 However, in practice I think we may as well just use a native blocking tokio thread here. There's a lot of shenanigans going on though because we're wrapping sync I/O with async and then back to sync because the tar code we're using is still sync. What would be a lot better is to move the compression to be inline with the sync tar parsing, but that would require some API changes and more code motion.
This was referenced Apr 29, 2024
cgwalters
force-pushed
the
no-async-decompress3
branch
from
83d9521
to
62c4564
Compare
travier
approved these changes
Apr 29, 2024
|
I'll test that e2e with rpm-ostree. |
|
I've pushed I get a "mixed" gzip/zstd-chunked image: And this gives me: |
|
Hum, OK this is weird, I've re-tried it and it worked! So looking good. Looks like it was only a quay.io infra flake. So this LGTM. |
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically just a workaround for Nullus157/async-compression#271
However, in practice I think we may as well just use
a native blocking tokio thread here.
There's a lot of shenanigans going on though because
we're wrapping sync I/O with async and then back to sync
because the tar code we're using is still sync.
What would be a lot better is to move the compression to be
inline with the sync tar parsing, but that would require some
API changes and more code motion.
Closes: #608