Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Make ManifestDiff serializable #619

Merged
merged 1 commit into from Apr 17, 2024

Conversation

cgwalters
Copy link
Member

But don't serialize the layers or manifests as that's large; just the numeric diff which is a lot smaller amount of data.

Fetching manifests and layers should be done via a dedicated API.

But don't serialize the layers or manifests as that's large;
just the numeric diff which is a lot smaller amount of data.

Fetching manifests and layers should be done via a dedicated
API.
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think that cover the full scope of #618 however?

@cgwalters
Copy link
Member Author

Yeah you're right, reopened that.

@cgwalters cgwalters merged commit 62bac42 into ostreedev:main Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants