lib/src/tar/write: make sure we add the links when filtering the tar #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrero
force-pushed
the
write-tars
branch
3 times, most recently
from
5f0bb35
to
52dfdbc
Compare
|
The output of: Shows: |
cgwalters
reviewed
Feb 18, 2022
lib/src/tar/write.rs
Outdated
Comment on lines
160
to
162
| // Need to use the entry.link_name not the header.link_name | ||
| // as it is shortened for some reason... | ||
| let target_link = entry.link_name()?; |
There was a problem hiding this comment.
I think it'd be cleanest if we dispatched on the entry type, like this:
match entry.header().entry_type() {
tar::EntryType::Link | tar::EntryType::Symlink => { /* use append_link() * }
o => { dest.append_data(&mut header, normalized, entry }
}
or so?
It's also worth referencing e.g. alexcrichton/tar-rs#192 here
Co-authored-by: Colin Walters <walters@verbum.org>
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Jun 9, 2022
This pulls in ostreedev/ostree-rs-ext#251 at least which I believe is the patch which fixes the errors we're seeing when package layering in some cases. xref https://bugzilla.redhat.com/show_bug.cgi?id=2095528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.