Commits on Dec 10, 2021

1. tar/export: Write symlink targets literally …

   Requires: alexcrichton/tar-rs#274
   
   And I'll just copy/paste the commit message from there, lightly edited:
   
   In https://github.com/ostreedev/ostree we generate a cryptographic
   checksum over files and symlinks, and directories.
   
   ostree does not currently perform any canonicalization on symlinks;
   we'll respect and honor whatever bytes we're provided as input,
   and replicate that on the target.
   
   We're using the Rust tar crate to do tar serialization,
   which has so far worked fine...except, I hit this corner case:
   
   ```
   [root@cosa-devsh ~]# rpm -qf /usr/lib/systemd/systemd-sysv-install
   chkconfig-1.13-2.el8.x86_64
   [root@cosa-devsh ~]# ll /usr/lib/systemd/systemd-sysv-install
   lrwxrwxrwx. 2 root root 24 Nov 29 18:08 /usr/lib/systemd/systemd-sysv-install -> ../../..//sbin/chkconfig
   [root@cosa-devsh ~]#
   ```
   
   But, using `set_link_name` to write the tarball, we end up with
   the canonicalized path `../../../sbin/chkconfig` - i.e. without the
   double `//`.  This breaks the checksum.
   
   Now, I am a bit tempted to change ostree to do canonicalization.  But
   even if we did, I'd need to *exactly* match what tar-rs is doing.
   
   (I may of course also try to change the rhel8 systemd package, but
    that's going to take a while to propagate and this corner case isn't
    the only one I'm sure)

   

   cgwalters committed Dec 10, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 7c66922
   • Browse repository at this point

   Copy the full SHA

   7c66922 View commit details

   Browse the repository at this point in the history