🌱 cron: don't write any bestpractices data for projects without repo URL #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still run into the 429 GCS responses due to the lower limits on the same file. All of the projects without a repo_url are being mapped to the same object and leading to rate limiting. "Maximum rate of writes to the same object name: One write per second" https://cloud.google.com/storage/quotas#objects Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
naveensrinivasan
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
cron fix
What is the current behavior?
We still run into the 429 GCS responses due to the lower limits on writes to the same object. All of the projects without a
repo_urlare being mapped to the same object/result.jsonand leading to rate limiting."Maximum rate of writes to the same object name: One write per second"
https://cloud.google.com/storage/quotas#objects
What is the new behavior (if this is a feature change)?**
We don't try to write anything for projects without an associated
repo_urlWhich issue(s) this PR fixes
Follow up of #4090 , related to #4037
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)