Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 attestor: e2e tests #2529

Merged
merged 3 commits into from Dec 12, 2022
Merged

Conversation

raghavkaul
Copy link
Contributor

What kind of change does this PR introduce?

Add E2E tests. Also refactor the check runner to allow dependency injection.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #2529 (ec0f515) into main (6107786) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2529      +/-   ##
==========================================
- Coverage   40.73%   40.69%   -0.05%     
==========================================
  Files         115      115              
  Lines        9613     9609       -4     
==========================================
- Hits         3916     3910       -6     
- Misses       5418     5419       +1     
- Partials      279      280       +1     

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Integration tests success for
[894f4e1]
(https://github.com/ossf/scorecard/actions/runs/3649934707)

attestor/command/check.go Show resolved Hide resolved
e2e/attestor_policy_test.go Outdated Show resolved Hide resolved
e2e/attestor_policy_test.go Outdated Show resolved Hide resolved
e2e/attestor_policy_test.go Outdated Show resolved Hide resolved
e2e/attestor_policy_test.go Outdated Show resolved Hide resolved
e2e/attestor_policy_test.go Show resolved Hide resolved
e2e/attestor_policy_test.go Show resolved Hide resolved
e2e/attestor_policy_test.go Show resolved Hide resolved
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
instead of all

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
@raghavkaul raghavkaul temporarily deployed to integration-test December 8, 2022 20:06 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Integration tests success for
[f0228ef]
(https://github.com/ossf/scorecard/actions/runs/3651706916)

Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc change LGTM.

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) December 12, 2022 18:55
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test December 12, 2022 18:55 — with GitHub Actions Inactive
@github-actions
Copy link

Integration tests success for
[ec0f515]
(https://github.com/ossf/scorecard/actions/runs/3678858186)

Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azeemshaikh38 azeemshaikh38 merged commit 7206a2b into ossf:main Dec 12, 2022
@raghavkaul raghavkaul deleted the tests-attestor branch December 12, 2022 20:27
raghavkaul added a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
* Add E2E tests

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Change RequiredApprovers so that it checks for any reviewers on the list
instead of all

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Co-authored-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants