Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Add soft mem limit to controller k8s spec #2362

Merged
merged 2 commits into from
Oct 18, 2022
Merged

馃尡 Add soft mem limit to controller k8s spec #2362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8f1c5
Bump golang docker to 1.19
spencerschrock Oct 17, 2022
ee3f29e
Add soft memory limit for controller to address OOMKilled.
spencerschrock Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang@sha256:ea3d912d500b1ae0a691b2e53eb8a6345b579d42d7e6a64acca83d274b949740 AS base
# golang:1.19
FROM golang@sha256:25de7b6b28219279a409961158c547aadd0960cf2dcbc533780224afa1157fd4 AS base
WORKDIR /src
ENV CGO_ENABLED=0
COPY go.* ./
Expand Down
3 changes: 2 additions & 1 deletion cron/internal/bq/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang@sha256:ea3d912d500b1ae0a691b2e53eb8a6345b579d42d7e6a64acca83d274b949740 AS base
# golang:1.19
FROM golang@sha256:25de7b6b28219279a409961158c547aadd0960cf2dcbc533780224afa1157fd4 AS base
WORKDIR /src
ENV CGO_ENABLED=0
COPY go.* ./
Expand Down
3 changes: 2 additions & 1 deletion cron/internal/cii/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang@sha256:ea3d912d500b1ae0a691b2e53eb8a6345b579d42d7e6a64acca83d274b949740 AS base
# golang:1.19
FROM golang@sha256:25de7b6b28219279a409961158c547aadd0960cf2dcbc533780224afa1157fd4 AS base
WORKDIR /src
ENV CGO_ENABLED=0
COPY go.* ./
Expand Down
3 changes: 2 additions & 1 deletion cron/internal/controller/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang@sha256:ea3d912d500b1ae0a691b2e53eb8a6345b579d42d7e6a64acca83d274b949740 AS base
# golang:1.19
FROM golang@sha256:25de7b6b28219279a409961158c547aadd0960cf2dcbc533780224afa1157fd4 AS base
WORKDIR /src
ENV CGO_ENABLED=0
COPY go.* ./
Expand Down
3 changes: 2 additions & 1 deletion cron/internal/webhook/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang@sha256:ea3d912d500b1ae0a691b2e53eb8a6345b579d42d7e6a64acca83d274b949740 AS base
# golang:1.19
FROM golang@sha256:25de7b6b28219279a409961158c547aadd0960cf2dcbc533780224afa1157fd4 AS base
WORKDIR /src
ENV CGO_ENABLED=0
COPY go.* ./
Expand Down
3 changes: 2 additions & 1 deletion cron/internal/worker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang@sha256:ea3d912d500b1ae0a691b2e53eb8a6345b579d42d7e6a64acca83d274b949740 AS base
# golang:1.19
FROM golang@sha256:25de7b6b28219279a409961158c547aadd0960cf2dcbc533780224afa1157fd4 AS base
WORKDIR /src
ENV CGO_ENABLED=0
COPY go.* ./
Expand Down
2 changes: 2 additions & 0 deletions cron/k8s/controller.release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ spec:
args: ["--config=/etc/scorecard/config.yaml", "cron/internal/data/projects.release.csv"]
imagePullPolicy: Always
env:
- name: GOMEMLIMIT
value: "950MiB"
- name: SCORECARD_REQUEST_TOPIC_URL
value: "gcppubsub://projects/openssf/topics/scorecard-batch-requests-releasetest"
- name: SCORECARD_DATA_BUCKET_URL
Expand Down
3 changes: 3 additions & 0 deletions cron/k8s/controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ spec:
image: gcr.io/openssf/scorecard-batch-controller:stable
args: ["--config=/etc/scorecard/config.yaml", "cron/internal/data/projects.csv"]
imagePullPolicy: Always
env:
- name: GOMEMLIMIT
value: "950MiB"
resources:
limits:
memory: 1Gi
Expand Down