✨ Add Language struct and optimize result parsing for GHClient.ListProgrammingLanguages #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng9867/scorecard into feat/897_go_fuzzer_check
…ng9867/scorecard into feat/897_go_fuzzer_check
…ng9867/scorecard into feat/897_go_fuzzer_check
…ng9867/scorecard into feat/897_go_fuzzer_check
aidenwang9867
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
aidenwang9867
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
+ Coverage 50.40% 52.94% +2.53%
==========================================
Files 88 88
Lines 7225 7236 +11
==========================================
+ Hits 3642 3831 +189
+ Misses 3337 3152 -185
- Partials 246 253 +7 |
|
Integration tests success for |
laurentsimon
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Besides @azeemshaikh38 's comment, no further comment from me!
|
Integration tests success for |
azeemshaikh38
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A follow-up PR on PR#1979.
Modify
type Language stringtotype LanguageName stringinclients/languages.go.Add a new struct
type Language struct {LanguageName, LoC}inclients/languages.go.Add support for interface
ListProgrammingLanguagesto parse the returned JSON to a list ofLanguage.Add more language name const:
CMakeandDockerFilePR title follows the guidelines defined in our pull request documentation
Does this PR introduce a user-facing change?
No.