Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Remove Options that belong to the Action #1898

Merged
merged 2 commits into from May 9, 2022
Merged

馃悰 Remove Options that belong to the Action #1898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c9465
updates
laurentsimon May 9, 2022
f66f7a4
tests
laurentsimon May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 6 additions & 8 deletions options/options.go
View file
Open in desktop
Expand Up @@ -28,22 +28,20 @@ import (

// Options define common options for configuring scorecard.
type Options struct {
Repo string `env:"GITHUB_REPOSITORY"`
Repo string
Local string
Commit string `env:"GITHUB_REF"`
Commit string
LogLevel string
Format string `env:"SCORECARD_RESULTS_FORMAT"`
Format string
NPM string
PyPI string
RubyGems string
PolicyFile string `env:"SCORECARD_POLICY_FILE"`
PolicyFile string
// TODO(action): Add logic for writing results to file
ResultsFile string `env:"SCORECARD_RESULTS_FILE"`
ChecksToRun []string `env:"SCORECARD_ENABLED_CHECKS"`
ResultsFile string
ChecksToRun []string
Metadata []string
ShowDetails bool
// TODO(action): Add logic for determining if results should be published.
PublishResults bool `env:"SCORECARD_PUBLISH_RESULTS"`

// Feature flags.
EnableSarif bool `env:"ENABLE_SARIF"`
Expand Down
2 changes: 0 additions & 2 deletions options/options_test.go
View file
Open in desktop
Expand Up @@ -37,7 +37,6 @@ func TestOptions_Validate(t *testing.T) {
ChecksToRun []string
Metadata []string
ShowDetails bool
PublishResults bool
EnableSarif bool
EnableScorecardV5 bool
EnableScorecardV6 bool
Expand Down Expand Up @@ -106,7 +105,6 @@ func TestOptions_Validate(t *testing.T) {
ChecksToRun: tt.fields.ChecksToRun,
Metadata: tt.fields.Metadata,
ShowDetails: tt.fields.ShowDetails,
PublishResults: tt.fields.PublishResults,
EnableSarif: tt.fields.EnableSarif,
EnableScorecardV5: tt.fields.EnableScorecardV5,
EnableScorecardV6: tt.fields.EnableScorecardV6,
Expand Down