Skip to content

Commit

Permalink
e2e fix
Browse files Browse the repository at this point in the history
  • Loading branch information
laurentsimon committed May 3, 2022
1 parent 183c86b commit ef246fc
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions e2e/binary_artifacts_test.go
Expand Up @@ -85,9 +85,6 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
NumberOfDebug: 0,
}
result := checks.BinaryArtifacts(&req)
// UPGRADEv2: to remove.
// Old version.
// New version.
Expect(scut.ValidateTestReturn(nil, "binary artifacts", &expected, &result, &dl)).Should(BeTrue())
Expect(repoClient.Close()).Should(BeNil())
})
Expand Down Expand Up @@ -115,7 +112,6 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
NumberOfDebug: 0,
}
result := checks.BinaryArtifacts(&req)
// New version.
Expect(scut.ValidateTestReturn(nil, "binary artifacts", &expected, &result, &dl)).Should(BeTrue())
Expect(repoClient.Close()).Should(BeNil())
})
Expand Down Expand Up @@ -161,11 +157,12 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
Repo: repo,
Dlogger: &dl,
}
// TODO: upload real binaries to the repo as well.
// TODO: upload real binaries to the repo.
// Existing binaries only contain SCII characters and are ignored.
expected := scut.TestReturn{
Error: nil,
Score: checker.MaxResultScore - 4,
NumberOfWarn: 4,
Score: checker.MaxResultScore,
NumberOfWarn: 0,
NumberOfInfo: 0,
NumberOfDebug: 0,
}
Expand Down Expand Up @@ -199,11 +196,12 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
Repo: repo,
Dlogger: &dl,
}
// TODO: upload real binaries to the repo as well.
// TODO: upload real binaries to the repo.
// Existing binaries only contain SCII characters and are ignored.
expected := scut.TestReturn{
Error: nil,
Score: checker.MaxResultScore - 4,
NumberOfWarn: 4,
Score: checker.MaxResultScore,
NumberOfWarn: 0,
NumberOfInfo: 0,
NumberOfDebug: 0,
}
Expand Down

0 comments on commit ef246fc

Please sign in to comment.