e2e fix

ossf · May 3, 2022 · 98dbc29 · 98dbc29
1 parent c95a257
commit 98dbc29
Showing 1 changed file with 10 additions and 14 deletions.
diff --git a/e2e/binary_artifacts_test.go b/e2e/binary_artifacts_test.go
@@ -85,10 +85,7 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
 				NumberOfDebug: 0,
 			}
 			result := checks.BinaryArtifacts(&req)
-			// UPGRADEv2: to remove.
-			// Old version.
-			Expect(result.Pass).Should(BeFalse())
-			// New version.
+
 			Expect(scut.ValidateTestReturn(nil, "binary artifacts", &expected, &result, &dl)).Should(BeTrue())
 			Expect(repoClient.Close()).Should(BeNil())
 		})
@@ -116,10 +113,7 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
 				NumberOfDebug: 0,
 			}
 			result := checks.BinaryArtifacts(&req)
-			// UPGRADEv2: to remove.
-			// Old version.
-			Expect(result.Pass).Should(BeFalse())
-			// New version.
+
 			Expect(scut.ValidateTestReturn(nil, "binary artifacts", &expected, &result, &dl)).Should(BeTrue())
 			Expect(repoClient.Close()).Should(BeNil())
 		})
@@ -165,11 +159,12 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
 				Repo:       repo,
 				Dlogger:    &dl,
 			}
-			// TODO: upload real binaries to the repo as well.
+			// TODO: upload real binaries to the repo.
+			// Existing binaries only contain SCII characters and are ignored.
 			expected := scut.TestReturn{
 				Error:         nil,
-				Score:         checker.MaxResultScore - 4,
-				NumberOfWarn:  4,
+				Score:         checker.MaxResultScore,
+				NumberOfWarn:  0,
 				NumberOfInfo:  0,
 				NumberOfDebug: 0,
 			}
@@ -203,11 +198,12 @@ var _ = Describe("E2E TEST:"+checks.CheckBinaryArtifacts, func() {
 				Repo:       repo,
 				Dlogger:    &dl,
 			}
-			// TODO: upload real binaries to the repo as well.
+			// TODO: upload real binaries to the repo.
+			// Existing binaries only contain SCII characters and are ignored.
 			expected := scut.TestReturn{
 				Error:         nil,
-				Score:         checker.MaxResultScore - 4,
-				NumberOfWarn:  4,
+				Score:         checker.MaxResultScore,
+				NumberOfWarn:  0,
 				NumberOfInfo:  0,
 				NumberOfDebug: 0,
 			}