Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization-wide Workflow Add Instructions #773

Closed
wants to merge 14 commits into from
Closed

Conversation

naveensrinivasan
Copy link
Member

I picked up the PR #151

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #773 (3973e3c) into main (7290c22) will decrease coverage by 11.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #773       +/-   ##
===========================================
- Coverage   74.80%   63.63%   -11.17%     
===========================================
  Files           2        4        +2     
  Lines         127      231      +104     
===========================================
+ Hits           95      147       +52     
- Misses         25       72       +47     
- Partials        7       12        +5     
Impacted Files Coverage Δ
options/env.go 100.00% <0.00%> (ø)
signing/signing.go 32.14% <0.00%> (ø)
multi-repo-action/main.go 0.00% <0.00%> (ø)
options/options.go 84.28% <0.00%> (+9.88%) ⬆️

@naveensrinivasan
Copy link
Member Author

@azeemshaikh38 @justaugustus @laurentsimon I need a 👍 to merge this in.

Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the multi-repo tool ready?
Last time I checked, it would need a bit of logic to detect whether a previous PR was sent or not, in order to avoid duplication of issues.

@naveensrinivasan
Copy link
Member Author

Is the multi-repo tool ready?
Last time I checked, it would need a bit of logic to detect whether a previous PR was sent or not, in order to avoid duplication of issues.

TBH I don't know. We can close this PR if it isn't ready. I picked up the long-running PR to close things.

@laurentsimon
Copy link
Contributor

Is the multi-repo tool ready?
Last time I checked, it would need a bit of logic to detect whether a previous PR was sent or not, in order to avoid duplication of issues.

TBH I don't know. We can close this PR if it isn't ready. I picked up the long-running PR to close things.

I think it'd be good to iron out some of the problems. I'm just hesitant to release this if people start finding problems. I think the main feature that would be useful it avoid spamming if a person provides a repository where an issue is already opened. That'd a cool PR to work on though.

Wdut?

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naveensrinivasan -- In lieu of updating the instructions, I would actually remove any mentions on the tool (, but not the tool itself).

I merged some initial fixes to multi-repo-action in #301, but it is still not in a working state and I think leaving instructions in about it may cause more overhead than we need.

@naveensrinivasan
Copy link
Member Author

@naveensrinivasan -- In lieu of updating the instructions, I would actually remove any mentions on the tool (, but not the tool itself).

I merged some initial fixes to multi-repo-action in #301, but it is still not in a working state and I think leaving instructions in about it may cause more overhead than we need.

I agree. There isn't any mention of the tool other than in its own folder and README. I will update the README with Work In Progress.

@naveensrinivasan
Copy link
Member Author

closing this for #776

auto-merge was automatically disabled July 26, 2022 21:57

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants