removed SCORECARD_PUBLISH_RESULTS env var

main.go

@@ -44,6 +44,7 @@ var (
 	enabledChecks                 = ""
 	scorecardPrivateRepository    = ""
 	scorecardDefaultBranch        = ""
+	scorecardPublishResults       = ""
 )
 
 type repositoryInformation struct {
@@ -61,17 +62,16 @@ const (
 	githubRef               = "GITHUB_REF"
 	githubWorkspace         = "GITHUB_WORKSPACE"
 	//nolint:gosec
-	githubAuthToken         = "GITHUB_AUTH_TOKEN"
-	inputresultsfile        = "INPUT_RESULTS_FILE"
-	inputresultsformat      = "INPUT_RESULTS_FORMAT"
-	inputpublishresults     = "INPUT_PUBLISH_RESULTS"
-	scorecardBin            = "/scorecard"
-	scorecardResultsFormat  = "SCORECARD_RESULTS_FORMAT"
-	scorecardPublishResults = "SCORECARD_PUBLISH_RESULTS"
-	scorecardPolicyFile     = "./policy.yml"
-	scorecardResultsFile    = "SCORECARD_RESULTS_FILE"
-	scorecardFork           = "SCORECARD_IS_FORK"
-	sarif                   = "sarif"
+	githubAuthToken        = "GITHUB_AUTH_TOKEN"
+	inputresultsfile       = "INPUT_RESULTS_FILE"
+	inputresultsformat     = "INPUT_RESULTS_FORMAT"
+	inputpublishresults    = "INPUT_PUBLISH_RESULTS"
+	scorecardBin           = "/scorecard"
+	scorecardResultsFormat = "SCORECARD_RESULTS_FORMAT"
+	scorecardPolicyFile    = "./policy.yml"
+	scorecardResultsFile   = "SCORECARD_RESULTS_FILE"
+	scorecardFork          = "SCORECARD_IS_FORK"
+	sarif                  = "sarif"
 )
 
 // main is the entrypoint for the action.
@@ -178,9 +178,7 @@ func initalizeENVVariables() error {
 		if result == "" {
 			return errInputPublishResultsEmpty
 		}
-		if err := os.Setenv(scorecardPublishResults, result); err != nil {
-			return fmt.Errorf("error setting %s: %w", scorecardPublishResults, err)
-		}
+		scorecardPublishResults = result
 	}
 
 	return gitHubEventPath()
@@ -303,9 +301,7 @@ func updateRepositoryInformation(privateRepo bool, defaultBranch string) error {
 func updateEnvVariables() error {
 	isPrivateRepo := scorecardPrivateRepository
 	if isPrivateRepo != "true" {
-		if err := os.Setenv(scorecardPublishResults, "false"); err != nil {
-			return fmt.Errorf("error setting %s: %w", scorecardPublishResults, err)
-		}
+		scorecardPublishResults = "false"
 	}
 	return nil
 }
@@ -317,7 +313,6 @@ func printEnvVariables(writer io.Writer) {
 	fmt.Fprintf(writer, "GITHUB_REPOSITORY=%s\n", os.Getenv(githubRepository))
 	fmt.Fprintf(writer, "SCORECARD_IS_FORK=%s\n", os.Getenv(scorecardFork))
 	fmt.Fprintf(writer, "Ref=%s\n", os.Getenv(githubRef))
-	fmt.Fprintf(writer, "SCORECARD_PUBLISH_RESULTS=%s\n", os.Getenv(scorecardPublishResults))
 	fmt.Fprintf(writer, "Format=%s\n", os.Getenv(scorecardResultsFormat))
 }
 

main_test.go

@@ -243,7 +243,7 @@ func Test_updateEnvVariables(t *testing.T) {
 				t.Errorf("updateEnvVariables() error = %v, wantErr %v", err, tt.wantErr)
 			}
 			if !tt.wantErr && tt.isPrivateRepo {
-				if os.Getenv(scorecardPublishResults) != "false" {
+				if scorecardPublishResults != "false" {
 					t.Errorf("scorecardPublishResults env var should be false")
 				}
 			}