options: Fix publish results logic

Signed-off-by: Stephen Augustus <foo@auggie.dev>
ossf · Feb 28, 2022 · 07e5f8d · 07e5f8d
1 parent d4bc1bc
commit 07e5f8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/entrypoint/entrypoint_test.go b/entrypoint/entrypoint_test.go
@@ -271,10 +271,11 @@ func TestUpdateEnvVariables(t *testing.T) {
 	for _, tt := range tests {
 		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			tt.opts.SetRepoVisibility(tt.isPrivateRepo)
 			tt.opts.SetPublishResults()
 			if !tt.wantErr && tt.isPrivateRepo {
 				if tt.opts.ScorecardPublishResults != "false" {
-					t.Errorf("scorecardPublishResults env var should be false")
+					t.Errorf("scorecardPublishResults env var (%s) should be false", tt.opts.ScorecardPublishResults)
 				}
 			}
 

diff --git a/options/options.go b/options/options.go
@@ -155,11 +155,11 @@ func (o *Options) SetDefaultBranch(defaultBranch string) error {
 // repository's visibility.
 func (o *Options) SetPublishResults() {
 	isPrivateRepo := o.RepoVisibility
-	if isPrivateRepo == "" {
+	if isPrivateRepo == "true" || isPrivateRepo == "" {
 		o.ScorecardPublishResults = "false"
+	} else {
+		o.ScorecardPublishResults = "true"
 	}
-
-	o.ScorecardPublishResults = isPrivateRepo
 }
 
 // GetGithubToken retrieves the GitHub auth token from the environment.