New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E testing for local images #602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt to Makefile Signed-off-by: Max Fisher <maxfisher@google.com>
Signed-off-by: Max Fisher <maxfisher@google.com>
…; adapt Makefile accordingly Signed-off-by: Max Fisher <maxfisher@google.com>
oliverchang
reviewed
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks Max! Just some questions.
…e examples/e2e and test/e2e use/override this, update READMEs accordingly Signed-off-by: Max Fisher <maxfisher@google.com>
Signed-off-by: Max Fisher <maxfisher@google.com>
oliverchang
approved these changes
Feb 1, 2023
Signed-off-by: Max Fisher <maxfisher@google.com>
Signed-off-by: Max Fisher <maxfisher@google.com>
oliverchang
approved these changes
Feb 1, 2023
Signed-off-by: Max Fisher <maxfisher@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a test/ directory and e2e subfolder which helps test locally built sandbox and analysis images. It is based off the existing examples/e2e folder, but requires building a specially tagged set of sandbox images
Signed-off-by: Max Fisher maxfisher@google.com