Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Map a declared license for PyPI::pytest-cov #159

Merged

Conversation

brunopacheco1
Copy link
Contributor

@brunopacheco1 brunopacheco1 requested a review from a team as a code owner December 19, 2023 11:51
@sschuberth
Copy link
Member

The library is licensed under MIT, but according to
this Pull Request,
the project metadata was mistakenly stating BSD License.

That's an interesting case. What's your take on this @willebra? Does this really make past releases MIT- instead of BSD-licensed?

PS: I've asked the maintainers to be explicit on that.

curations/PyPI/_/pytest-cov.yml Show resolved Hide resolved
curations/PyPI/_/pytest-cov.yml Outdated Show resolved Hide resolved
@brunopacheco1 brunopacheco1 changed the title chore: Add PyPI::pytest-cov curation to version 4.1.0 chore: Map a declared license for PyPI::pytest-cov Apr 19, 2024
@willebra
Copy link

@sschuberth I think this looks quite a genuine error at the project side, and I don't have doubts based on the history and the linked commits. The license-file has remained MIT all the time. And setup.py had internally conflicting statements in history, i.e. MIT and BSD License statements, both at the same time, prior to the correction. After correction, it is MIT in every place.

Also any risk is quite low, considering the very similar obligations of these licenses, of course the BSD-ststement has been quite vague.

I could treat all the historical versions also as MIT.

@brunopacheco1 brunopacheco1 force-pushed the support-pytest-cov branch 2 times, most recently from c733d9c to 0eb35a6 Compare April 19, 2024 19:48
comment: |
The LICENSE file always contained only the 'MIT' license text, while the project metadata accidentally
declared it to be licensed under 'BSD License' for all version prior to 2.12.0, see also
pytest-dev/pytest-cov@2cd0094
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this a full, clickable link. And better link the PR, which has some additional background information, i.e https://github.com/pytest-dev/pytest-cov/pull/467.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was meaning to actually replace the link with only the link to the PR, which already contains the diff for the commit, so there is not need to link the commit as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, no problem, just fixed the commit.

fviernau
fviernau previously approved these changes Apr 22, 2024
Signed-off-by: Bruno Pacheco <brunopacheco1@yahoo.com>
@sschuberth sschuberth merged commit 05631ff into oss-review-toolkit:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants