Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_wamv.py should not produce a compliance error on an empty WAMV #658

Merged
merged 4 commits into from
May 25, 2023
Merged

generate_wamv.py should not produce a compliance error on an empty WAMV #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4fdcf1
return True if yaml file is empty
M1chaelM May 23, 2023
82134bf
update CI
M1chaelM May 23, 2023
6c75d1f
fix Ubuntu version
M1chaelM May 23, 2023
a147788
overriding container user
M1chaelM May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,22 @@ name: Ubuntu CI
on: [pull_request]

jobs:
test-fortress-galactic:
test-humble-garden:

runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
container:
image: npslearninglab/watery_robots:humble_current
options: --user root
steps:
- run: sudo chown -R `whoami`:`whoami` .
- name: Checkout vrx
uses: actions/checkout@v2.4.0
uses: actions/checkout@v3
with:
ref: main
path: vrx

- name: Checkout Gazebosim
uses: actions/checkout@v2.4.0
uses: actions/checkout@v3
with:
repository: gazebosim/ros_gz
ref: humble
Expand Down
2 changes: 1 addition & 1 deletion vrx_urdf/vrx_gazebo/src/vrx_gazebo/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def create_xacro_file(xacro_target,
if requested_macros is None:
xacro_file.write(boiler_plate_bot)
xacro_file.close()
return
return True

# Object must be available
for key, objects in requested_macros.items():
Expand Down