Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2:devel / ros2:nightly] install colcon from pip and not apt #272

Merged
merged 1 commit into from Jun 4, 2019

Conversation

mikaelarguedas
Copy link
Contributor

Related to ros2/ros2#722

Fixes #270

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@ruffsl
Copy link
Member

ruffsl commented Jun 4, 2019

Would this PR be reverted once the packaging issue with pytest is resolved? I recall we previously migrated away from installing colcon from pip to apt for downstream consistency of dev tools.

Related: pytest-dev/pytest#5389

@mikaelarguedas
Copy link
Contributor Author

Would this PR be reverted once the packaging issue with pytest is resolved?

Originally the goal is to install all the third-party tools from APT and not pip to allow conflict tracking and automatic upgrade.
In this particular case, I'm not convinced it needs to be reverted.
As this PR targets only the images that are expected to be built daily it shouldn't be too big of a deal to install colcon from pip. It also allows to move away from the error prone pattern of installing some pytest plugins from pip and the others from APT.
I doubt the fix will ever make it to bionic so we will need to install pytest via pip to get it.

@ruffsl
Copy link
Member

ruffsl commented Jun 4, 2019

I doubt the fix will ever make it to bionic so we will need to install pytest via pip to get it.

Ah, that would do it.
Does this mean that library/ros:dashing images are left with a broken build tool?

@mikaelarguedas
Copy link
Contributor Author

Does this mean that library/ros:dashing images are left with a broken build tool?

No they should be fine as they dont install any plugins from pip. They just are not able to leverage the various pytest options that colcon provides (I think, I haven't built or tried the dashing images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ros2:source fails to build because pytest cant be found
2 participants