implement NewBatchWithSize method on DB interface to pre-allocate buffer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Feb 24, 2022
| @@ -63,6 +63,9 @@ type DB interface { | |||
| // NewBatch creates a batch for atomic updates. The caller must call Batch.Close. | |||
| NewBatch() Batch | |||
|
|
|||
| // NewBatch creates a batch for atomic updates with pre-allocated buffer. The caller must call Batch.Close. | |||
| NewBatchWithSize(size int) Batch | |||
There was a problem hiding this comment.
part of me thinks it would make sense to not break that api and merely use it goleveldb. Unless we see improvements on rocks and others
There was a problem hiding this comment.
Agreed.
I'm making changes to IAVL now to benchmark how much of a difference this change makes. I will come back here after and look into other databases. Otherwise, rethink this PR
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Ethereum recently discovered that growing the buffer on goleveldb is slow and implemented a fix:
ethereum/go-ethereum#24392
This PR introduced the same method with pre-allocated buffer to tm-db