Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocksdb state sync script #826

Closed
wants to merge 10 commits into from
Closed

Rocksdb state sync script #826

wants to merge 10 commits into from

Conversation

faddat
Copy link
Member

@faddat faddat commented Feb 4, 2022

Closes: #695

Description

This adds statesync-rocks.bash to the scripts folder. It is a rocksdb compatible state sync script for osmosis.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@faddat faddat changed the title Rocksdb & statesync Don't Merge: Rocksdb & statesync Feb 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #826 (eaca1dc) into v6.x (3bf63f1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v6.x     #826   +/-   ##
=======================================
  Coverage   19.06%   19.06%           
=======================================
  Files         167      167           
  Lines       23684    23684           
=======================================
  Hits         4516     4516           
  Misses      18387    18387           
  Partials      781      781           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf63f1...eaca1dc. Read the comment docs.

@faddat
Copy link
Member Author

faddat commented Feb 16, 2022

I think that I now have enough information to use this as where I make the rocksdb guide.

I've been missing an ldflags thing when I build with rocksdb.

I've got enough info now to guide users trhough "the right way"

@faddat faddat changed the title Don't Merge: Rocksdb & statesync Rocksdb state sync guide Feb 16, 2022
@faddat faddat changed the title Rocksdb state sync guide Rocksdb state sync script Feb 16, 2022
@faddat
Copy link
Member Author

faddat commented Feb 16, 2022

To get this in, I'm going to mark this as ready for review and bundle docs with #876

@faddat faddat marked this pull request as ready for review February 16, 2022 01:15
@ValarDragon
Copy link
Member

Sorry didn't notice this getting marked ready for review, my bad

@faddat
Copy link
Member Author

faddat commented Mar 1, 2022

@ValarDragon no problem.

I think I should close this for now, and focus on work upstream to make state sync work with wasm

I know you've been really busy, here's what we are up to right now, I reckon it can/will affect osmo later:

cosmos/cosmos-sdk#11096 (comment)

@faddat faddat closed this Mar 1, 2022
@ValarDragon
Copy link
Member

ValarDragon commented Mar 1, 2022

Thanks for the info! Hyped for getting state syncing and rocksDB working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants