Initial auth for endpoints #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petterhj
force-pushed
the
teams-api-client
branch
from
d275aa7
to
25374db
Compare
simenheg
reviewed
Sep 3, 2021
simenheg
reviewed
Sep 10, 2021
tox.ini
Outdated
| @@ -4,13 +4,19 @@ envlist = py39, flake8, black | |||
| [testenv] | |||
| deps = | |||
| pytest | |||
| responses | |||
There was a problem hiding this comment.
Hva er forskjellen på denne og requests-mock som vi har brukt andre steder?
There was a problem hiding this comment.
Lurte på om starlette/fastapi TestClient kanskje lekte litt bedre med responses enn requests-mock, uten å måtte aktivere real_http. Skal dog sies jeg ikke undersøkte så mye nærmere, og litt for å prøve noe annet.
There was a problem hiding this comment.
Ah! Satt akkurat med det problemet tidligere i uka faktisk... Ser ut som responses er mer populært også, 3.3k stjerner på GitHub vs 260.
petterhj
force-pushed
the
teams-api-client
branch
from
7d8d27b
to
7db4b92
Compare
|
Men denne må kanskje settes litt på pause nå som vi ikke skal ha det selvbetjent i første omgang? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.