Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing issue #300 #302

Merged
merged 2 commits into from
Mar 26, 2022
Merged

Addressing issue #300 #302

merged 2 commits into from
Mar 26, 2022

Conversation

fangohr
Copy link
Member

@fangohr fangohr commented Mar 25, 2022

Fixes #300 locally.

(We should have a test for the correct creation of the html pages.)

@github-actions
Copy link

View web reports generated with this branch at staging/302/

@fangohr
Copy link
Member Author

fangohr commented Mar 26, 2022

The tests pass, so hopefully this has fixed the issues.

@fangohr fangohr merged commit 4944b59 into master Mar 26, 2022
@fangohr fangohr deleted the issue-300 branch March 26, 2022 07:31
@kirienko
Copy link
Collaborator

Well, nice that it works, but we also need to pin the rest. Otherwise quite soon something else will screw up because of incompatibility with that particular jinja2 version :)

@fangohr
Copy link
Member Author

fangohr commented Mar 26, 2022

Well, nice that it works, but we also need to pin the rest. Otherwise quite soon something else will screw up because of incompatibility with that particular jinja2 version :)

Absolutely! I have created an issue already. #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook building fail 24 March 2022
2 participants