Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook building fail 24 March 2022 #300

Open
fangohr opened this issue Mar 25, 2022 · 4 comments · Fixed by #302
Open

Notebook building fail 24 March 2022 #300

fangohr opened this issue Mar 25, 2022 · 4 comments · Fixed by #302
Labels
bug Something isn't working nbconvert

Comments

@fangohr
Copy link
Member

fangohr commented Mar 25, 2022

We have a new error: https://github.com/oscovida/oscovida.github.io/runs/5688255990?check_suite_focus=true#step:6:281

As we have not changed anything, I guess this comes from changing behaviour of dependencies which we do not pin.

I suggest we pick up @kirienko 's proposal of pinning all versions (once we have this working again).

This page shows which runs completed and which failed: https://github.com/oscovida/oscovida.github.io/actions

@fangohr fangohr added the bug Something isn't working label Mar 25, 2022
@kirienko
Copy link
Collaborator

Seems to be an indirect dependency problem.
So the actual problem is in jinja2 due to the update to 3.1.0. Namely, they say that Markup and escape should be imported from MarkupSafe. But I don't see the place where we import jinja2 explicitly.

@kirienko
Copy link
Collaborator

Aha! That's nbconvert again!

@kirienko
Copy link
Collaborator

kirienko commented Mar 25, 2022

Okay, the problem is that nbconvert still uses the old import.
Here is an open issue: jupyter/nbconvert#1737
When it is solved, I think our issue will be gone too. There is a pull request made but I don't know how fast it will propagate. But on the other hand, untangling this dependency knot manually might be painful and will end up with a fragile solution.

fangohr added a commit that referenced this issue Mar 26, 2022
@fangohr fangohr reopened this Mar 26, 2022
@fangohr
Copy link
Member Author

fangohr commented Mar 26, 2022

Issue was closed by accident.

I have fixed the Jinja2 version in both environments (i.e. for oscovida itself, defined in setup.py, and for the requirements for the vent for pelican (requirements_pelican.txt ).

All the tests pass then. I have merged, and am waiting for the outcome of the webpage regeneration attempt.https://github.com/oscovida/oscovida.github.io/actions/runs/2043845872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nbconvert
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants