Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase range of supported versions of python #1540

Closed
wants to merge 8 commits into from

Conversation

butler54
Copy link
Collaborator

@butler54 butler54 commented May 13, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

GitHub actions is now defaulting to python 3.12 when the python version is not specified. There was a breaking change for compliance-trestle in a fresh environment as setuptools is no longer included by default in a python environment / venv.

To merge this PR, required versions of the pipelines will need to be updated in the branch protection configuration

Key links:

Before you merge

  • Ensure it is a 'squash commit'
  • Ensure CI is currently passing
  • Is this a merge to develop from any branch except main and ghpages

Signed-off-by: Chris Butler chris.butler@redhat.com

Signed-off-by: Chris Butler <chris.butler@redhat.com>
@butler54 butler54 changed the title fix: Increase range of supported versions of python fix: increase range of supported versions of python May 13, 2024
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
@butler54 butler54 added bug Something isn't working refactor For issues relating to altering the way existing functionality is presented within the trestle. dependencies labels May 13, 2024
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
@degenaro
Copy link
Collaborator

As part of PR #1533 which is under review and should result in a new release of trestle very soon, the versions of python tested (therefore supported) will change to {3.9, 3.10. 3.11}. The reasons are two fold. One is that it is desirable to have at least one version of python (3.9) that is the same as the previous release. The other is that supporting too many version of python causes the test matrix to expand and the test time to increase, so we keep it at 3 versions. We project that a future release will use {3.10. 3.11, 3.12}. Please feel free to review and comment on the aforementioned PR. With respect to github action versions, that too would be a good candidate for a near term follow-up once the 1.1.2 trestle support release happens.

@butler54
Copy link
Collaborator Author

As part of PR #1533 which is under review and should result in a new release of trestle very soon, the versions of python tested (therefore supported) will change to {3.9, 3.10. 3.11}. The reasons are two fold. One is that it is desirable to have at least one version of python (3.9) that is the same as the previous release. The other is that supporting too many version of python causes the test matrix to expand and the test time to increase, so we keep it at 3 versions. We project that a future release will use {3.10. 3.11, 3.12}. Please feel free to review and comment on the aforementioned PR. With respect to github action versions, that too would be a good candidate for a near term follow-up once the 1.1.2 trestle support release happens.

Supporting 3.12 is a small change in the trestle code itself (moving setuptools to be required to install, as well as develop trestle). Given the small cost of the change, and the availability of 3.12 in the ecosystem (3.13 is coming shortly) it might be worth introducing as well. For 3.7-3.11 the only difference is that setuptools is always already installed.

In terms of the bulk of the changes for the CICD pipeline which is broken today, it's a question of whether you are happy to wait or not. The most broken part of the pipeline is support for macos 3.7 - which I could refactor a minimal fix to unblock the current PRs.

@butler54
Copy link
Collaborator Author

I'm closing this given the upstream changes.

@butler54 butler54 closed this May 29, 2024
@butler54 butler54 deleted the cleanup-dependencies branch May 29, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies refactor For issues relating to altering the way existing functionality is presented within the trestle.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants