-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase range of supported versions of python #1540
Conversation
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
As part of PR #1533 which is under review and should result in a new release of trestle very soon, the versions of python tested (therefore supported) will change to {3.9, 3.10. 3.11}. The reasons are two fold. One is that it is desirable to have at least one version of python (3.9) that is the same as the previous release. The other is that supporting too many version of python causes the test matrix to expand and the test time to increase, so we keep it at 3 versions. We project that a future release will use {3.10. 3.11, 3.12}. Please feel free to review and comment on the aforementioned PR. With respect to github action versions, that too would be a good candidate for a near term follow-up once the 1.1.2 trestle support release happens. |
Supporting 3.12 is a small change in the trestle code itself (moving In terms of the bulk of the changes for the CICD pipeline which is broken today, it's a question of whether you are happy to wait or not. The most broken part of the pipeline is support for macos 3.7 - which I could refactor a minimal fix to unblock the current PRs. |
I'm closing this given the upstream changes. |
Types of changes
Quality assurance (all should be covered).
Summary
GitHub actions is now defaulting to python 3.12 when the python version is not specified. There was a breaking change for
compliance-trestle
in a fresh environment assetuptools
is no longer included by default in a python environment / venv.To merge this PR, required versions of the pipelines will need to be updated in the branch protection configuration
Key links:
Before you merge
develop
from any branch exceptmain
andghpages
Signed-off-by: Chris Butler chris.butler@redhat.com