Add support for arbitrary kickstart file injection into ISOs (HMS-3879) #4135
+50,767
−44,371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
images/update/user-kickstarts
branch
2 times, most recently
from
d6a0d49
to
e068cac
Compare
|
Rebased on #4157 |
achilleas-k
requested review from
ondrejbudai
and removed request for
ondrejbudai
achilleas-k
force-pushed
the
images/update/user-kickstarts
branch
from
e068cac
to
078cbac
Compare
ochosi
changed the title
achilleas-k
force-pushed
the
images/update/user-kickstarts
branch
2 times, most recently
from
7ab0e49
to
c870e00
Compare
🤔 |
|
Seems the issue is actually |
The osbuild repo (and CI building RPMs) probably uses newer rpmrepo snapshots with newer selinux-policy package. |
|
ah of course, didn't think of that. Thanks! |
--- updated-dependencies: - dependency-name: cloud.google.com/go/compute dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: cloud.google.com/go/storage dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-deps - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-deps - dependency-name: github.com/osbuild/images dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-deps - dependency-name: github.com/vmware/govmomi dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-deps - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps ... Signed-off-by: dependabot[bot] <support@github.com>
Pulling in (among others): - osbuild/images#700 - Blueprint User customization change required. - osbuild/images#705
|
Pulled in #4147 |
achilleas-k
force-pushed
the
images/update/user-kickstarts
branch
from
c870e00
to
d9f510d
Compare
thozza
previously approved these changes
May 23, 2024
|
Also found the issue that I noticed here: #4147 (comment) |
openssl gets installed as a dependency of the osbuild-composer-tests but it might not update openssh at the same time, which can cause a version mismatch when running ssh-keygen: OpenSSL version mismatch. Built against 30000000, you have 30200010 This is currently happening in CentOS Stream 9 so let's make sure openssh is up to date before running ssh-keygen.
achilleas-k
force-pushed
the
images/update/user-kickstarts
branch
from
6433b8f
to
7551bb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in (primarily):