gen-manifests: derrive seedArg from filename and env #4124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that manifests get random(ish) and stable UUIDs we set the seed arg based on the filename and the environment (`OSBUILD_GEN_MANIFEST_RNG_SEED`). This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors.
|
I think we might want to get rid of this cmd and only keep the one in images. We'd have retool some things in manifest-db maybe so let's discuss it tomorrow and do it all then. |
|
Unless this is urgent |
mvo5
added a commit
to mvo5/images
that referenced
this pull request
May 6, 2024
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename. This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors. This is the same as osbuild/osbuild-composer#4124 hopefully for the right place this time.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
May 6, 2024
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename. This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors. This is the same as osbuild/osbuild-composer#4124 hopefully for the right place this time.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
May 8, 2024
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename. This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors. This is the same as osbuild/osbuild-composer#4124 hopefully for the right place this time.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
May 14, 2024
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename. This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors. This is the same as osbuild/osbuild-composer#4124 hopefully for the right place this time.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
May 14, 2024
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename. This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors. This is the same as osbuild/osbuild-composer#4124 hopefully for the right place this time.
|
If we get rid of this command I will close this PR and open one that removes the command - otherwise we could simply import the helper from osbuild/images#674 here now |
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
May 14, 2024
To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename. This should fix the issue discovered in osbuild/manifest-db#124 that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors. This is the same as osbuild/osbuild-composer#4124 hopefully for the right place this time.
mvo5
added a commit
to mvo5/osbuild-composer
that referenced
this pull request
May 16, 2024
This is a result of the outcome of osbuild#4124 Achilleas suggested that instead of having a copy of `gen-manifests` in osbuild-composer we could use the one from images. AFAICT nothing in the code references `gen-manifests` except the `test/README` so it seems safe to remove and just run the one from images. Note that osbuild/images#693 needs to land before: ``` go run github.com/osbuild/images/cmd/gen-manifests@latest ``` works.
|
Closing in favor of #4152 |
mvo5
added a commit
to mvo5/osbuild-composer
that referenced
this pull request
May 17, 2024
This is a result of the outcome of osbuild#4124 Achilleas suggested that instead of having a copy of `gen-manifests` in osbuild-composer we could use the one from images. AFAICT nothing in the code references `gen-manifests` except the `test/README` so it seems safe to remove and just use images. The README got updated to point to `images` and we will also need to remove `test/data/manifest` at a later point (after checking that nothing else depends on this anymore).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that manifests get random(ish) and stable UUIDs we set the seed arg based on the filename and the environment (
OSBUILD_GEN_MANIFEST_RNG_SEED).This should fix the issue discovered in
osbuild/manifest-db#124
that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors.
[draft as it lacks testing, I don't know yet how to do that]