Makefile for templates/openshift #4103
Open
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just for manual checks if the template syntax is fine
croissanne
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Hmm I wonder if this makes sense to put in the makefile. The only reason we process them in the github workflow is so that kubelinter can do a very basic check. The processing of the template when actually deploying is something that is out of our hands. If we put it in the makefile, then i'd just consider it as a helper for the github workflow.
|
We could use it from GitHub Workflow but I just wanted to call it so see if there are syntax problems locally (avoid GitHub Action problems before pushing - the usual problem) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to check #4102 locally.
maybe that's helpful for someone