Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudapi: Add UploadTypesLocal for local_save status reports #4038

Merged
merged 1 commit into from May 13, 2024

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Mar 25, 2024

This allows the compose status to reflect that it was saved locally, not uploaded to a remote service. Without this it returns an error of 'Compose has unknown upload target'

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcl bcl enabled auto-merge (rebase) April 5, 2024 21:43
@bcl bcl force-pushed the main-localsave-status branch 2 times, most recently from 803d903 to eaf3ceb Compare April 10, 2024 22:41
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 11, 2024
@bcl bcl removed the Stale label May 13, 2024
This allows the compose status to reflect that it was saved locally, not
uploaded to a remote service. Without this it returns an error of
'Compose has unknown upload target'
@bcl bcl merged commit 66c5c5e into osbuild:main May 13, 2024
48 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants