Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor user customization test improvements #4007

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andremarianiello
Copy link

@andremarianiello andremarianiello commented Mar 13, 2024

Extend user customizations to include an expiration date. This allows users to be configured to require password change on first login.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

@andremarianiello andremarianiello changed the title Update osbuild/image to <waiting on tag> Support new ExpireDate field in users customization Mar 13, 2024
@andremarianiello andremarianiello force-pushed the add-user-expiredate branch 2 times, most recently from ac36323 to bda14f2 Compare March 22, 2024 14:22
@andremarianiello andremarianiello marked this pull request as ready for review March 26, 2024 14:47
@andremarianiello
Copy link
Author

osbuild/images got a tag with the necessary changes, so I have updated this PR to depend on that tag and I also made a doc change PR, so I think this is ready to go. Thanks!

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looks like you accidentally squashed your commit into the image update commit, there's only one commit now.

@andremarianiello andremarianiello force-pushed the add-user-expiredate branch 2 times, most recently from f7f2ef7 to f36902a Compare March 27, 2024 14:19
@andremarianiello
Copy link
Author

I looks like you accidentally squashed your commit into the image update commit, there's only one commit now.

This has been a single commit I think since I opened it. I think you may be thinking of my PR in osbuild/images that had a separate commit for the go fmt change, so I will do the same thing here.

@andremarianiello
Copy link
Author

Done. Go fmt changes to customizations_test.go are separated into their own commit.

@andremarianiello andremarianiello force-pushed the add-user-expiredate branch 2 times, most recently from ab701e8 to 4adc0b3 Compare March 28, 2024 13:54
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now I see 2 commits. But the one with the title 'Update osbuild/image to v0.51.0' isn't doing that. And the body of it says it is doing things to user customizations when all it is doing is adding the field to the customizations test. So the commit message on that one needs to be fixed.

@andremarianiello
Copy link
Author

Ok, now I see 2 commits. But the one with the title 'Update osbuild/image to v0.51.0' isn't doing that. And the body of it says it is doing things to user customizations when all it is doing is adding the field to the customizations test. So the commit message on that one needs to be fixed.

A different PR that bumped osbuild/images up to v0.51.0 got merged already (1ce7207) and when I rebased the source branch of this PR on top of the target branch it eliminated 95% of the changes and only some inconsequential bits are left. If you still want the little bits that are left I can fix the commit messages. If you don't I can close it. What do you prefer?

@bcl
Copy link
Contributor

bcl commented Mar 29, 2024

yeah, seems worthwhile to clean things up, thanks!

@andremarianiello
Copy link
Author

yeah, seems worthwhile to clean things up, thanks!

Done!

@andremarianiello andremarianiello changed the title Support new ExpireDate field in users customization Minor user customization test improvements Apr 1, 2024
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bcl bcl enabled auto-merge (rebase) April 8, 2024 23:18
@andremarianiello
Copy link
Author

Looks like some checks need to be rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants