Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge: extract the common functions and put in one place for Edge test… #3966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Edge: extract the common functions and put in one place for Edge test… #3966

wants to merge 1 commit into from
+353 −1,717

Conversation

litian1992
Copy link

@litian1992 litian1992 commented Feb 21, 2024 •
edited

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@litian1992 litian1992 force-pushed the edge-li branch 4 times, most recently from 46a6019 to 8ffa76b Compare March 5, 2024 03:12
@litian1992 litian1992 force-pushed the edge-li branch 8 times, most recently from 71a5204 to e049eea Compare March 7, 2024 06:15
@litian1992 litian1992 force-pushed the edge-li branch 4 times, most recently from f4a7e44 to 6818123 Compare March 27, 2024 07:04
henrywang
henrywang previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@henrywang henrywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@henrywang henrywang enabled auto-merge (rebase) March 28, 2024 14:08
@litian1992
Copy link
Author

Hello @ondrejbudai Can you please help me merge this? It passed all Edge tests. And the failed ones are irrelevant to this PR, I think. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 9, 2024
@litian1992 litian1992 removed the Stale label May 9, 2024
@bcl
Copy link
Contributor

bcl commented May 10, 2024

Hello @ondrejbudai Can you please help me merge this? It passed all Edge tests. And the failed ones are irrelevant to this PR, I think. Thank you!

Currently there are conflicts with newer changes to osbuild-composer, you need to rebase and resolve those first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvo5 mvo5 mvo5 left review comments

@henrywang henrywang henrywang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@litian1992 @bcl @henrywang @mvo5