New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add custom partition mount points to raw image test case #3884
Draft
mcattamoredhat
wants to merge
1
commit into
osbuild:main
Choose a base branch
from
mcattamoredhat:fs-custom-lvs-raw-image
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
test: add custom partition mount points to raw image test case #3884
mcattamoredhat
wants to merge
1
commit into
osbuild:main
from
mcattamoredhat:fs-custom-lvs-raw-image
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
3 times, most recently
from
January 10, 2024 10:05
a3ef38e
to
e0c8440
Compare
say-paul
reviewed
Jan 10, 2024
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
from
January 10, 2024 13:03
e0c8440
to
92126d2
Compare
say-paul
reviewed
Jan 11, 2024
lets hold this off until osbuild/images#352 is resolved |
mcattamoredhat
changed the title
test: add custom lvs to edge-raw-image test case
test: add custom partition mount points to edge-raw-image test case
Jan 19, 2024
djach7
previously approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, reviewed for English conventions with basic go knowledge
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
from
January 26, 2024 12:15
92126d2
to
4aeedcd
Compare
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
5 times, most recently
from
February 2, 2024 16:47
512d13c
to
bbfaee3
Compare
mcattamoredhat
changed the title
test: add custom partition mount points to edge-raw-image test case
test: add custom partition mount points to raw image test case
Feb 2, 2024
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
from
February 5, 2024 13:26
bbfaee3
to
7a26de2
Compare
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
3 times, most recently
from
February 19, 2024 14:52
1bc2e36
to
d1668d0
Compare
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
from
February 21, 2024 11:35
d1668d0
to
a299598
Compare
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
2 times, most recently
from
April 1, 2024 14:54
279b0cd
to
f81b03b
Compare
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
2 times, most recently
from
April 10, 2024 09:39
656ff80
to
4f09ab6
Compare
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
4 times, most recently
from
April 18, 2024 09:34
18ebdb2
to
bc3cc3c
Compare
mcattamoredhat
force-pushed
the
fs-custom-lvs-raw-image
branch
from
April 30, 2024 08:38
bc3cc3c
to
b91db65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
This PR adds custom partitions to blueprint of edge-raw-image, making use of the example comments at RHEL 9: Filesystem customizations for edge-raw-image
A playbook task has been included to check the custom partitions using
lvdisplay