Local container manifest-lists #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok, although I worry a bit about changing the signature of a public function. |
Yeah valid. I can handle it inside the function rather. Still need to re-think how we handle the second commit since that route no longer seems feasible. |
We can simplify the get manifest resolver by passing the digest to the `src.GetManifest`. When the primary manifest is a manifest list, passing in the instance digest will retrieve the manifest for the instance.
Attempting to resolve the container image arch on a manifest list results in an error. We should skip this instead and only check this if the image is a container image.
We can resolve a local manifest list by querying the local storage for the image by the instance digest. We can then resolve the container by the id for the desired arch.
kingsleyzissou
force-pushed
the
local-container-manifests
branch
from
d693dc4
to
29b2486
Compare
|
Closing this in favour of #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would unblock:
But is blocked by: