Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to force LPAR to set defaults in NVRAM before booting #19290

Merged
merged 1 commit into from May 16, 2024

Conversation

alvarocarvajald
Copy link
Contributor

@alvarocarvajald alvarocarvajald commented May 13, 2024

This commit introduces the SET_NVRAM_DEFAULTS setting, that will cause the functions in lib/bootloader_pvm.pm to boot the LPAR into the Open Firmware command line prompt and issue a SET_NVRAM_DEFAULTS to reset the values in the LPAR's NVRAM to its defaults. This can help to fix some boot issues caused by aborted boot processes in the LPAR, which in turn prevent the GRUB menu from being loaded. If set, LPAR will boot into the Open Firmware prompt, issue the command and then continue to boot normally. If not set, it will boot as usual.

[type description here, PLEASE, REMOVE THIS LINE, PLACEHOLDER, BEFORE SUBMITTING THIS PULL REQUEST]

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

lib/bootloader_pvm.pm Outdated Show resolved Hide resolved
lib/bootloader_pvm.pm Outdated Show resolved Hide resolved
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some comments and questions

@alvarocarvajald
Copy link
Contributor Author

VR after latest changes: http://mango.qe.nue2.suse.org/tests/5820

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/bootloader_pvm.pm Outdated Show resolved Hide resolved
This commit introduces the `SET_NVRAM_DEFAULTS` setting, that will cause
the functions in lib/bootloader_pvm.pm to boot the LPAR into the Open
Firmware command line prompt and issue a `SET_NVRAM_DEFAULTS` to reset
the values in the LPAR's NVRAM to its defaults. This can help to fix
some boot issues caused by aborted boot processes in the LPAR, which
in turn prevent the GRUB menu from being loaded. If set, LPAR will boot
into the Open Firmware prompt, issue the command and then continue to
boot normally. If not set, it will boot as usual.
@alvarocarvajald alvarocarvajald merged commit c748fcc into os-autoinst:master May 16, 2024
10 checks passed
@alvarocarvajald alvarocarvajald deleted the set_nvram_def branch May 16, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants