P.C. create_instance logs list fix #19285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-dati
requested review from
pdostal,
grisu48,
asmorodskyi,
ricardobranco777 and
mpagot
as code owners
pdostal
reviewed
May 11, 2024
pdostal
approved these changes
May 11, 2024
ricardobranco777
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During logs upload in
create_instance, the sshlscheck returns the 'list of file to upload' with an unexpected '\t' in place of space separator, causing names fusion in the tar command, then error. See i.e. job 14271031.After attempts to purify the spaces of the string representing the file-list, the better stable and successful solution resulted to convert filenames in array then join members in the tar command.