Add needle check for successful iPXE start before changing boot device #19102
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we boot slow systems, a hard-coded timeout is either too long or too short, depending on the hardware used. Instead of guessing, we should add a needle check to see when iPXE has successfully started to load a kernel image, then we can safely change UEFI boot device again.
frankenmichl
force-pushed
the
add_ipxe_needle
branch
from
760dab7
to
eab8168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we boot slow systems, a hard-coded timeout is either too long or too short, depending on the hardware used.
Instead of guessing, we should add a needle check to see when iPXE has successfully started to load a kernel image, then we can safely change UEFI boot device again.
[type description here, PLEASE, REMOVE THIS LINE, PLACEHOLDER, BEFORE SUBMITTING THIS PULL REQUEST]