feat(otelx): add support for the GRPC protocol in Otel #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alecsammon
changed the title
alecsammon
changed the title
alecsammon
changed the title
5 tasks
alecsammon
commented
May 20, 2024
| @@ -85,22 +85,23 @@ require ( | |||
| go.opentelemetry.io/contrib/propagators/b3 v1.21.0 | |||
| go.opentelemetry.io/contrib/propagators/jaeger v1.21.1 | |||
| go.opentelemetry.io/contrib/samplers/jaegerremote v0.15.1 | |||
| go.opentelemetry.io/otel v1.21.0 | |||
| go.opentelemetry.io/otel v1.26.0 | |||
There was a problem hiding this comment.
required update to support GRPC.
This brought in the other dependency updates.
alecsammon
commented
May 20, 2024
| var client otlptrace.Client | ||
| if c.Providers.OTLP.Transport == "GRPC" { | ||
| client = getOTLPGRPClient(c) | ||
| } else { |
There was a problem hiding this comment.
It may be required to add http/json and http/protobuf in the future. At the moment we default to the current behaviour
https://opentelemetry.io/docs/specs/otel/protocol/exporter/#specify-protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our system cannot currently accept Otel data via
http. As such we need support to send this using theGRPCtransport option.This PR adds a new property to allow this to be specified - with the current
httpas the default option to prevent any breaking changes.Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments