Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuration of resources in keto automigration initcont… #677

Merged

Conversation

dlahn
Copy link
Contributor

@dlahn dlahn commented May 10, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there!
I see no reason for not adding this :) However, I would have one request: for the sake of consistency could you add the field to other chars that use the initcontainer, and not only keto?

@dlahn
Copy link
Contributor Author

dlahn commented May 13, 2024

@Demonsthere I just did a check and it looks like in the other charts it is already configurable. This change is actually mostly mirrored from Kratos.

@dlahn
Copy link
Contributor Author

dlahn commented May 15, 2024

@Demonsthere Do you think this is good to go?

@Demonsthere Demonsthere merged commit fa20c68 into ory:master May 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants