Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch from lib/pq to jackc/pgx #1736

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

glerchundi
Copy link
Contributor

Closes #1599

@claassistantio
Copy link

claassistantio commented Feb 20, 2020

CLA assistant check
All committers have signed the CLA.

@glerchundi
Copy link
Contributor Author

Do not merge this one until ory/x#118 is merged so that I could remove the replace thing from go.mod.

@glerchundi glerchundi changed the title *: switch from lib/pq to jackc/{pgconn,pgx} refactor: switch from lib/pq to jackc/{pgconn,pgx} Feb 20, 2020
@glerchundi glerchundi force-pushed the refactor/switch-to-pgx branch 2 times, most recently from 21b34d0 to 7fcd905 Compare February 20, 2020 20:30
@glerchundi glerchundi changed the title refactor: switch from lib/pq to jackc/{pgconn,pgx} refactor: switch from lib/pq to jackc/pgx Feb 20, 2020
@glerchundi
Copy link
Contributor Author

glerchundi commented Feb 20, 2020

I think this is failing due to gorp not identifying pgx driver. Perhaps it would be interesting to keep the same driver by wrapping it? WrapDriver("postgres", "pgx").

WDYT?

Done: "if pgx then dialect = postgres", change was made in ory/x.

@glerchundi
Copy link
Contributor Author

@aeneasr PTAL.

@aeneasr aeneasr merged commit ec78668 into ory:master Feb 23, 2020
@aeneasr
Copy link
Member

aeneasr commented Feb 23, 2020

Thank you! Released as a new version

aeneasr added a commit that referenced this pull request Feb 23, 2020
aeneasr added a commit that referenced this pull request Feb 23, 2020
@glerchundi
Copy link
Contributor Author

glerchundi commented Feb 23, 2020 via email

eli-zh pushed a commit to eli-zh/hydra that referenced this pull request Mar 22, 2020
eli-zh pushed a commit to eli-zh/hydra that referenced this pull request Mar 22, 2020
@glerchundi glerchundi deleted the refactor/switch-to-pgx branch December 27, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra write to database: broken pipe
3 participants