Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade go version to 1.18 #496

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

build: upgrade go version to 1.18 #496

wants to merge 2 commits into from

Conversation

takclark
Copy link

@takclark takclark commented Feb 16, 2024

GitHub Action tests have been failing since this run. It's caused by dependency on strings.Cut, which was added in 1.18 and appeared in dependency https://github.com/docker/cli some time between v20.10.17 and v24.0.1.

So, go 1.18 is the minimum required version here. This should fix the tests.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@takclark takclark changed the title bump go version build: upgrade go version to 1.18 Feb 16, 2024
@takclark
Copy link
Author

and you can now see "Nancy" failing on the runc version because of CVE-2024-21626, which I would also like to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant