Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use defer instead of os.Exit(m.Run()) #493

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

pmenglund
Copy link
Contributor

as of go1.15 testing.M returns the return code of m.Run(), so it is possible to use defer

Related Issue or Design Document

golang/go#34129

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

n/a

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
All committers have signed the CLA.

as of go1.15 `testing.M` returns the return code of `m.Run()`, so it is
possible to use `defer`
golang/go#34129
@pmenglund
Copy link
Contributor Author

this fails on something unrelated to the PR:

Error: ../../../go/pkg/mod/github.com/docker/cli@v24.0.1+incompatible/cli/compose/template/template.go:242:14: undefined: strings.Cut

do you want me to fix the issue in this PR or a separate one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants