Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added AuthConfigs to BuildOptions and pass that to BuildImage #488

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

DGollings
Copy link

Please consider this a 'naive PR' - we ran into an issue where although it was possible to pass along authentication to the run commands but not the build.

This fixes it, but I'm wondering why this wasn't already possible or whether I'm doing something else wrong

And i'm wondering why dockertest did not use already present and logged in ~/.docker/config.json

Either way, thanks for dockertest, it has already been used tens of thousands of times by us :)

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants