Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BuildKit when building images #374

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

juanfont
Copy link

@juanfont juanfont commented Jul 30, 2022

Docker/Mobi now has two builders: the classic one, and the one that comes under the buildx command ("BuildKit"). This new plugin adds better support for multi-platform images https://docs.docker.com/build/buildx/multiplatform-images/.

This small PR updates BuildOptions and docker.BuildImageOptions to include a new field Version, that is used to specify which builder should be used, as per https://github.com/docker/engine/blob/19.03/api/types/client.go#L185

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added necessary documentation within the code base (if
    appropriate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant