Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set password to launch postgres container #241

Merged
merged 1 commit into from Dec 3, 2020

Conversation

potix2
Copy link
Contributor

@potix2 potix2 commented Dec 2, 2020

I fixed all broken tests in CI.

The tests were failed because the testing containers launched without default password.

Related issue

Nothing

Proposed changes

Set a password as an environment variable on launching testing container.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2020

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr merged commit 22557cf into ory:v3 Dec 3, 2020
@aeneasr
Copy link
Member

aeneasr commented Dec 3, 2020

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants