feat(deprecated): Warn when resolving npm packages marked as `depreca…

…ted` (#184) Fixes: #157
orogene · Feb 28, 2023 · 45a953b · 45a953b
1 parent b227eb3
commit 45a953b
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/node-maintainer/Cargo.toml b/crates/node-maintainer/Cargo.toml
@@ -15,6 +15,7 @@ oro-common = { version = "=0.2.2", path = "../oro-common" }
 oro-package-spec = { version = "=0.2.2", path = "../oro-package-spec" }
 
 async-std = { workspace = true }
+colored = { workspace = true }
 futures = { workspace = true }
 kdl = { workspace = true }
 miette = { workspace = true }

diff --git a/crates/node-maintainer/src/maintainer.rs b/crates/node-maintainer/src/maintainer.rs
@@ -6,11 +6,12 @@ use std::sync::atomic::{self, AtomicUsize};
 #[cfg(not(target_arch = "wasm32"))]
 use async_std::fs;
 use async_std::sync::{Arc, Mutex};
+use colored::*;
 use futures::{StreamExt, TryFutureExt, TryStreamExt};
 #[cfg(not(target_arch = "wasm32"))]
 use indicatif::{ProgressBar, ProgressStyle};
 use nassun::{Nassun, NassunOpts, Package, PackageSpec};
-use oro_common::CorgiManifest;
+use oro_common::{CorgiManifest, CorgiVersionMetadata};
 use petgraph::stable_graph::NodeIndex;
 use petgraph::visit::EdgeRef;
 use petgraph::Direction;
@@ -459,7 +460,28 @@ impl NodeMaintainer {
 
                     if let Some(deps) = deps {
                         in_flight -= deps.len();
-                        let manifest = package.corgi_metadata().await?.manifest;
+
+                        let CorgiVersionMetadata {
+                            manifest,
+                            deprecated,
+                            ..
+                        } = &package.corgi_metadata().await?;
+
+                        if let Some(deprecated) = deprecated {
+                            pb.suspend(|| {
+                                tracing::warn!(
+                                    "{} {}@{}: {}",
+                                    "deprecated".magenta(),
+                                    manifest.name.as_ref().unwrap(),
+                                    manifest
+                                        .version
+                                        .as_ref()
+                                        .map(|v| v.to_string())
+                                        .unwrap_or_else(|| "unknown".into()),
+                                    deprecated
+                                );
+                            });
+                        }
 
                         for dep in deps {
                             if let Some(child_idx) =

diff --git a/crates/oro-common/src/packument.rs b/crates/oro-common/src/packument.rs
@@ -74,6 +74,8 @@ pub struct CorgiVersionMetadata {
     pub has_shrinkwrap: Option<bool>,
     #[serde(flatten)]
     pub manifest: CorgiManifest,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub deprecated: Option<String>,
 }
 
 /// A manifest for an individual package version.
@@ -111,6 +113,7 @@ impl From<VersionMetadata> for CorgiVersionMetadata {
             dist: value.dist.into(),
             has_shrinkwrap: value.has_shrinkwrap,
             manifest: value.manifest.into(),
+            deprecated: value.deprecated,
         }
     }
 }