Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable jsx-pascal-case [no issue] #407

Merged
merged 2 commits into from Jul 10, 2020
Merged

fix: disable jsx-pascal-case [no issue] #407

merged 2 commits into from Jul 10, 2020

Conversation

christophehurpeau
Copy link
Contributor

No description provided.

@reviewflow
Copy link

reviewflow bot commented Jul 10, 2020 •
edited

Options:

  • This PR is a feature branch
  • Add [skip ci] on merge commit
  • Auto merge when this PR is ready and has no failed statuses. (Also has a queue per repo to prevent multiple useless "Update branch" triggers)
  • Automatic branch delete after this PR is merged

ChibiBlasphem
ChibiBlasphem reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ChibiBlasphem ChibiBlasphem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On essaie de résoudre quelle problématique en désactivant cette règle ?

@christophehurpeau
Copy link
Contributor Author

<Typography.div /> throw une erreur avec la derrière version de eslint-plugin-react (que j'ai update pour data-testid)

@christophehurpeau
Copy link
Contributor Author

Teste de commenter sur la desactivation de la regle sur cette pr, tu auras l'erreur dans le test que j'ai rajouté

@ChibiBlasphem
Copy link
Contributor

Ce que je ne comprend pas c'est "en attente de la résolution du bug" ? Car effectivement il y'a une issue mais de ce que je vois dans les commentaires : Typography.div ne sera pas accepté faudra forcément que div soit en pascal case
jsx-eslint/eslint-plugin-react#1334 (comment)

Btw, l'issue est par rapport a un faux négatif, si jamais on avait Typography.Div

@christophehurpeau
Copy link
Contributor Author

ah ! ...

@christophehurpeau
Copy link
Contributor Author

En effet, je vais voir si on peut utiliser ignore

@ChibiBlasphem
Copy link
Contributor

Oui je me doute qu'on veuille garder notre Typography.div sans qu'on puisse avoir <myComponent>
Pour ignore au vu de la doc de la rule je pense que c'est possible

ChibiBlasphem
ChibiBlasphem approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ChibiBlasphem ChibiBlasphem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophehurpeau christophehurpeau merged commit 1f07c91 into master Jul 10, 2020
@reviewflow reviewflow bot deleted the fix/disable-jsx-pascal-case branch July 10, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChibiBlasphem ChibiBlasphem ChibiBlasphem approved these changes

Assignees

@christophehurpeau christophehurpeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophehurpeau @ChibiBlasphem