Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): avoid copying volume inside container #142

Merged
merged 3 commits into from May 18, 2023

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Feb 4, 2023

A different way to work around the problems noted in #108, c.f trailing comments in #109.

@alerque alerque requested a review from orhun as a code owner February 4, 2023 14:41
@alerque
Copy link
Contributor Author

alerque commented Feb 4, 2023

Untested because I have to run out, but this is roughly the approach I took on some other projects adapted for the way this project is laid out.

@codecov-commenter
Copy link

Codecov Report

Base: 43.24% // Head: 43.24% // No change to project coverage 👍

Coverage data is based on head (8251eef) compared to base (38943e8).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   43.24%   43.24%           
=======================================
  Files          12       12           
  Lines         562      562           
=======================================
  Hits          243      243           
  Misses        319      319           
Flag Coverage Δ
unit-tests 43.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@orhun
Copy link
Owner

orhun commented Feb 4, 2023

Looks like git is not installed in debian:buster-slim image.

@alerque
Copy link
Contributor Author

alerque commented Feb 4, 2023

Interesting. We can probably just echo the config to the file in /etc. My project is also a Rust + libgit2 one and it reads that config, but my Docker container also happened to have git available so that was an easy way to get setup.

@alerque alerque marked this pull request as draft February 4, 2023 18:18
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@orhun
Copy link
Owner

orhun commented Feb 14, 2023

@alerque Can you check out if this actually works?

@orhun
Copy link
Owner

orhun commented Mar 31, 2023

Kind ping @alerque

@alerque alerque force-pushed the docker-perms branch 3 times, most recently from 49d350a to 754b942 Compare April 22, 2023 20:03
@alerque alerque marked this pull request as ready for review April 22, 2023 20:12
Dockerfile Show resolved Hide resolved
@orhun orhun added this to the 1.3.0 milestone May 3, 2023
@orhun orhun changed the title Avoid copying project files inside container refactor(docker): avoid copying volume inside container May 18, 2023
@orhun orhun merged commit 65d365c into orhun:main May 18, 2023
19 of 20 checks passed
@welcome
Copy link

welcome bot commented May 18, 2023

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants