Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation SEO, refactoring #1148

Merged
merged 26 commits into from Jul 26, 2022
Merged

Conversation

astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu commented Jul 22, 2022

Description

This pull request aims to improve the SEO and the structure of the Orchest documentation.

  • For the SEO improvements I drew inspiration from a couple of similar pull requests made in Dask (Better SEO for 10 Minutes to Dask dask/dask#9182, Better SEO for Delayed and Best Practices dask/dask#9194) apart from other sources. In particular, I added .. meta descriptions to all pages, :alt: text to all figures, and be more careful with headers and wording in general.
  • For the structure, I drew inspiration from the Diátaxis documentation framework, which is widely used in the community. I noticed two things:
    • The "How to..." page contained lots of almost empty sections, which was annoying when doing searches. e.g. I would search for "git", click the first result, and realize that it was just a link to somewhere else ("your princess is in another castle"). I removed those sections and left only the ones that still made sense, and renamed that document FAQ.
    • There was some reference information (according to Diátaxis: understanding-oriented theoretical knowledge), so I created a separate Reference section that now contains the SDK, the CLI, and the keyboard shortcuts. One could say that the Glossary also fits here.

image

As a side effect, I continued converting some documents to MyST. To review, select the commit range ignoring the first two ones, which (1) upgrade docutils and (2) do all the conversions at once without touching the content. I did not convert all because this PR already moves some stuff around, so I preferred to not touch those documents that got heavily refactored.

Checklist

  • I have manually tested my changes and I am happy with the result.
  • The documentation reflects the changes.
  • The PR branch is set up to merge into dev instead of master.
  • I haven't introduced breaking changes that would disrupt existing jobs, i.e. backwards compatibility is maintained.
  • In case I changed the dependencies in any requirements.in I have run pip-compile to update the corresponding requirements.txt.
  • In case I changed one of the services' models.py I have performed the appropriate database migrations (refer to the DB migration docs).
  • In case I changed code in the orchest-sdk I followed its release checklist.
  • In case I changed code in the orchest-cli I followed its release checklist.

@astrojuanlu
Copy link
Contributor Author

🤖 Rendered version: https://orchest--1148.org.readthedocs.build/en/1148/

@astrojuanlu astrojuanlu force-pushed the improv/docs-seo-refactoring branch 2 times, most recently from 442765d to 8b25594 Compare July 22, 2022 15:55
@astrojuanlu astrojuanlu changed the title WIP: Improve documentation SEO, refactoring Improve documentation SEO, refactoring Jul 24, 2022
@astrojuanlu astrojuanlu marked this pull request as ready for review July 24, 2022 14:34
Copy link
Contributor

@ncspost ncspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ncspost ncspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannickperrenet
Copy link
Contributor

The "How to..." page contained lots of almost empty sections, (...), and renamed that document FAQ.

From the last Docker based Orchest version we link to: https://docs.orchest.io/en/stable/getting_started/how_to.html#migrate-to-kubernetes. This link would no longer we working with the removal of the page.

Is there a possibility of setting up a redirect?

@astrojuanlu
Copy link
Contributor Author

Is there a possibility of setting up a redirect?

Luckily yes! https://docs.readthedocs.io/en/stable/user-defined-redirects.html

@astrojuanlu
Copy link
Contributor Author

Merging, we can continue fixing smaller stuff in later pull requests 👍🏽 Thanks both!

@astrojuanlu astrojuanlu merged commit a39f9b3 into dev Jul 26, 2022
@astrojuanlu astrojuanlu deleted the improv/docs-seo-refactoring branch July 26, 2022 09:04
@astrojuanlu
Copy link
Contributor Author

Hmm pre-commit just failed with an unexpected minor thing 🤔 On it

@astrojuanlu
Copy link
Contributor Author

gh-1154

@astrojuanlu
Copy link
Contributor Author

From the last Docker based Orchest version we link to: https://docs.orchest.io/en/stable/getting_started/how_to.html#migrate-to-kubernetes. This link would no longer we working with the removal of the page.

Redirect added 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants