Add a loginWithTLS function to V1 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@souleb @shizhMSFT any concerns merging this? |
@shizhMSFT requested @deitch review before merging. |
If implemented, a client will accept custom certificate and certificate authority to authenticate with a remote registry. Signed-off-by: Soule BA <bah.soule@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #217
If implemented, a client will accept custom certificate and certificate authority to authenticate with a remote registry.
We ended up copying several unexported functions from upstream in order to be able to implement this.
Signed-off-by: Soule BA bah.soule@gmail.com